This course will become read-only in the near future. Tell us at community.p2pu.org if that is a problem.

Fix a bug



Fix a bug

  1. In your group, decide on a bug on github
  2. Leave a comment on the bug saying that your group has taken it
  3. Make changes, test, commit with descriptions as you go
  4. When done, push to your github account
  5. Do a pull request

Writing Task:

Did you run into any stumbling blocks? How'd you overcome them? What'd you learn? Any ideas for how to improve the process? Did you like pairing/grouping? What's the next bug/task you're going to tackle?

Task Discussion


  • Satyakam Goswami said:

    is the lighthouse site still relavant or we should follow by fixing issues on  https://github.com/p2pu/lernanta/issues?direction=desc&labels=easy+contribution&sort=created&state=open

     

    -Satya

    on Dec. 8, 2012, 11:08 p.m.

    Dirk said:

    You are right, thanks for catching that!!

    I'll update the link in this task.

    on Dec. 10, 2012, 10:10 a.m. in reply to Satyakam Goswami
  • Faheem Patel said:

    Would anyone like to partner up? I'd love to make a contribution but feel quite out of my depth.

    on June 9, 2011, 7:10 a.m.

    Vladimir Támara Patiño said:

    Of course, please let me know in which bug are you interested  ?

    on June 16, 2011, 5:23 a.m. in reply to Faheem Patel
  • rlo said:

    I can't seem to push my committed changes , i get this error

     

    (lernanta)rich@ubuntu:~/lernanta$ git push origin css-edits
    fatal: remote error:
      You can't push to git://github.com/p2pu/lernanta.git
      Use git@github.com:p2pu/lernanta.git
     

    Any ideas?

    Thanks

    on June 1, 2011, 12:48 a.m.

    Jessica Ledbetter said:

    You have pull access to that repository but not push access. Usually what we do is copy (fork) the project so that you own a copy and then push to there. From there, you submit a pull request to the p2pu/lernanta (upstream) project.

    More on forking: http://help.github.com/fork-a-repo/

    More on commiting: https://github.com/p2pu/lernanta/wiki/Github-Cheat-Sheet

    And, finally, more on pull requests: http://help.github.com/pull-requests/

    These are under "Adopting a task" on https://github.com/p2pu/lernanta/wiki so maybe we should make it a little more clear. Do you have some suggestions?

    on June 1, 2011, 10:52 a.m. in reply to rlo

    rlo said:

    The instructions are actually quite clear, seems my environment was a but iffy. Worked fine after i reinstalled everything. The only suggestion I have is include the merging of the branch to the master in the cheat sheet.

    git checkout master
    git merge mybranch
    git branch -d mybranch

    Cheers!

    on June 1, 2011, 9:55 p.m. in reply to Jessica Ledbetter

    Jessica Ledbetter said:

    Great idea! I think you have access to make that change. If not, let me know and I'll do it :)

    on June 3, 2011, 12:51 p.m. in reply to rlo
  • Jessica Ledbetter said:

    For those on this step, now's the perfect time to grab the bugs you want to tackle. We can always do the easy ones then do harder later :) Just because the study group finishes doesn't mean you can't keep contributing!

    Again, here's the list of the easier bugs to tackle on the Lighthouse bug tracker.

    If you would like personal feedback on which bug might be best for you, let me know and I'll give you my opinion.

    To claim a bug you just need to post a comment on that ticket saying that you are working on it. If you don't think you'll be able to be finished by June 1 note that too. We can change the milestone for you.

    on May 25, 2011, 12:05 p.m.

    Faheem Patel said:

    Thanks Jessica.

    Are we working in groups for this part?

    on May 25, 2011, 12:44 p.m. in reply to Jessica Ledbetter

    Jessica Ledbetter said:

    Up to the participants. Do you want to?

    on May 25, 2011, 4:22 p.m. in reply to Faheem Patel
  • Charles Tanton said:

    To keep my momentum going I am going to see if I can find a bug that I'm comfortable attempting on my own, but I believe there's a lot one could learn from working with someone else, so I'd be keen to pair up with someone too, if anyone else is keen :-)

    I'm going to take on a frontend task just to get my feet wet, but I'd like to pair with someone who's taking on a bug on the backend so that I could learn more about django and python. Perhaps just to watch and learn, given my limited knowledge of django...

    on May 19, 2011, 2:14 p.m.

    Jessica Ledbetter said:

    I agree about using this as an opportunity to build up our skills in working with others. I know pair programming has its challenges but doing it at a distance introduces another set.

    I think the task you grabbed is great and really needed. If you want more feedback on it, you can take it to the development or community lists. Not everyone gets updates each comment on Lighthouse :)

    Our next release is in two weeks so good timeline for people to come together and work on something. If two people are new to Django/Python, that's OK. Could mock up what you're thinking and get feedback from the group or dev list. 

    I'm looking through 0.7 list for some good not-so-easy but not-too-hard backend type tasks for this. Maybe this would work well: http://p2pu.lighthouseapp.com/projects/71002/tickets/77-notifications-update-frequency

    This would probably include model changes as well as frontend changes. We would probably need a cron added as well. It could start with mockups/wireframes/sketches on how it would behave/look and go from there. 

    on May 23, 2011, 12:40 p.m. in reply to Charles Tanton

    Zuzel Vera said:

    Let me know if you need help (selecting a bug/ticket, or figuring out where things are located in the code or the django docs).

    In the backend some of the bits that are probably familar for you are the drupal.py modules (e.g., https://github.com/p2pu/lernanta/blob/master/apps/projects/drupal.py). -- Thanks for the hint about the school/course relatinship last week. I used it to implement http://new.p2pu.org/en/groups/import/ with the help of inspectdb.

    on May 25, 2011, 12:32 p.m. in reply to Charles Tanton

    Charles Tanton said:

    Thanks Jessica and Zuzel - just a question about testing locally: Am I correct saying that setting up a dev environment will leave you with a site that has no study groups or people? Or have I missed something? Then to test should I just create my own study group and tasks?

    on May 26, 2011, 3:45 p.m. in reply to Jessica Ledbetter

    Jessica Ledbetter said:

    There are some fixtures (stored data that is great for this) but they're just for the "static" pages so menuing works and helped make it easy to get the data to Zuzel.

    So, yes, you will need to create a person and group locally.

    on May 26, 2011, 3:49 p.m. in reply to Charles Tanton